8:23 a.m.
I use this a bit to switch my shell buffer to the directory of the
file from the current buffer, e.g. editing file and want to do a git
commit.
At some point it seems to have stopped changing the current working
directory for the shell itself. I've looked a little and it seems the
shell-cd function used by emacspeak-wizards-shell-toggle doesn't
change the shell's working directory.
Looking at the relevant commits:
git diff 9eaa5db1cbdb fab2a5cc74452d2 emacspeak-wizards.el
diff --git a/lisp/emacspeak-wizards.el b/lisp/emacspeak-wizards.el
index 4a2a85621..572349bba 100644
--- a/lisp/emacspeak-wizards.el
+++ b/lisp/emacspeak-wizards.el
@@ -735,10 +735,7 @@ If optional arg property is not supplied, read it interactively.
"
(shell)
(unless (string-equal (expand-file-name dir)
(expand-file-name default-directory))
- (goto-char (point-max))
- (insert (format "pushd %s" dir))
- (comint-send-input)
- (shell-process-cd dir))
+ (shell-cd dir))
(emacspeak-auditory-icon 'select-object)
(emacspeak-speak-mode-line)))
It looks like explicit interaction with the shell process was removed.
Was that the intent? fwiw I prefer the old behaviour.
cheers
Peter
--
Peter Rayner (he/him), Level 1, 187 Grattan St.
Academic Lead - Climate & Energy College
<https://www.climatecollege.unimelb.edu.au>
mobile +61 402 752 379, skype: petermorag
zoom id 4431343191, join at
<https://unimelb.zoom.us/j/4431343191?pwd=a1E5Z3JEOTRVQUJsaVdRbVUvR1QyZz09...
mail-to: prayner(a)unimelb.edu.au TWITTER: @raynerstrings
I acknowledge the Traditional Custodians of the land on which I work, the Wurundjeri
people of the Kulin nation, and pay my respect to their Elders, past and present
I am sending this email when convenient for me, please only respond when convenient for
you
3:27 p.m.
prayner--- via Emacspeak <emacspeak(a)emacspeak.org> writes:
good catch -- will restore old behavior. I myself no longre use that
command, I have replaced that with emacspeak-wizards-shell-by-key in my
workflow. I thought shell-cd worked when I made the change, not sure
when it stopped working. From memory made the change because shell-cd
felt more robust than stuffing strings at the shell, e.g. that can fail
if the shell is already doing something else
I use this a bit to switch my shell buffer to the directory of the
file from the current buffer, e.g. editing file and want to do a git
commit.
At some point it seems to have stopped changing the current working
directory for the shell itself. I've looked a little and it seems the
shell-cd function used by emacspeak-wizards-shell-toggle doesn't
change the shell's working directory.
Looking at the relevant commits:
git diff 9eaa5db1cbdb fab2a5cc74452d2 emacspeak-wizards.el
diff --git a/lisp/emacspeak-wizards.el b/lisp/emacspeak-wizards.el
index 4a2a85621..572349bba 100644
--- a/lisp/emacspeak-wizards.el
+++ b/lisp/emacspeak-wizards.el
@@ -735,10 +735,7 @@ If optional arg property is not supplied, read it interactively.
"
(shell)
(unless (string-equal (expand-file-name dir)
(expand-file-name default-directory))
- (goto-char (point-max))
- (insert (format "pushd %s" dir))
- (comint-send-input)
- (shell-process-cd dir))
+ (shell-cd dir))
(emacspeak-auditory-icon 'select-object)
(emacspeak-speak-mode-line)))
It looks like explicit interaction with the shell process was removed.
Was that the intent? fwiw I prefer the old behaviour.
cheers
Peter
--
Thanks,
--Raman(I Search, I Find, I Misplace, I Research)
♈ Id: kg:/m/0285kf1 🦮
3:29 p.m.
prayner--- via Emacspeak <emacspeak(a)emacspeak.org> writes:
I just tried it C-e F11 and it does change the directory correctly.
I use this a bit to switch my shell buffer to the directory of the
file from the current buffer, e.g. editing file and want to do a git
commit.
At some point it seems to have stopped changing the current working
directory for the shell itself. I've looked a little and it seems the
shell-cd function used by emacspeak-wizards-shell-toggle doesn't
change the shell's working directory.
Looking at the relevant commits:
git diff 9eaa5db1cbdb fab2a5cc74452d2 emacspeak-wizards.el
diff --git a/lisp/emacspeak-wizards.el b/lisp/emacspeak-wizards.el
index 4a2a85621..572349bba 100644
--- a/lisp/emacspeak-wizards.el
+++ b/lisp/emacspeak-wizards.el
@@ -735,10 +735,7 @@ If optional arg property is not supplied, read it interactively.
"
(shell)
(unless (string-equal (expand-file-name dir)
(expand-file-name default-directory))
- (goto-char (point-max))
- (insert (format "pushd %s" dir))
- (comint-send-input)
- (shell-process-cd dir))
+ (shell-cd dir))
(emacspeak-auditory-icon 'select-object)
(emacspeak-speak-mode-line)))
It looks like explicit interaction with the shell process was removed.
Was that the intent? fwiw I prefer the old behaviour.
cheers
Peter
--
Thanks,
--Raman(I Search, I Find, I Misplace, I Research)
♈ Id: kg:/m/0285kf1 🦮
11:07 p.m.
Ok, could you also test manually that it's shell-cd that's changing
the directory?
Oh and thanks for pointing out emacspeak-wizards-shell-by-key. I
should reread emacspeak-wizards.el more often.
thanks again
Peter
T.V Raman writes:
prayner--- via Emacspeak <emacspeak(a)emacspeak.org> writes:
I just tried it C-e F11 and it does change the directory correctly.
> I use this a bit to switch my shell buffer to the directory of the
> file from the current buffer, e.g. editing file and want to do a git
> commit.
> At some point it seems to have stopped changing the current working
> directory for the shell itself. I've looked a little and it seems the
> shell-cd function used by emacspeak-wizards-shell-toggle doesn't
> change the shell's working directory.
> Looking at the relevant commits:
> git diff 9eaa5db1cbdb fab2a5cc74452d2 emacspeak-wizards.el
>
> diff --git a/lisp/emacspeak-wizards.el b/lisp/emacspeak-wizards.el
> index 4a2a85621..572349bba 100644
> --- a/lisp/emacspeak-wizards.el
> +++ b/lisp/emacspeak-wizards.el
> @@ -735,10 +735,7 @@ If optional arg property is not supplied, read it interactively.
"
> (shell)
> (unless (string-equal (expand-file-name dir)
> (expand-file-name default-directory))
> - (goto-char (point-max))
> - (insert (format "pushd %s" dir))
> - (comint-send-input)
> - (shell-process-cd dir))
> + (shell-cd dir))
> (emacspeak-auditory-icon 'select-object)
> (emacspeak-speak-mode-line)))
> It looks like explicit interaction with the shell process was removed.
> Was that the intent? fwiw I prefer the old behaviour.
> cheers
> Peter
--
Thanks,
--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1 🦮
--
Peter Rayner (he/him), Level 1, 187 Grattan St.
Academic Lead - Climate & Energy College
<https://www.climatecollege.unimelb.edu.au>
mobile +61 402 752 379, skype: petermorag
zoom id 4431343191, join at
<https://unimelb.zoom.us/j/4431343191?pwd=a1E5Z3JEOTRVQUJsaVdRbVUvR1QyZz09...
mail-to: prayner(a)unimelb.edu.au TWITTER: @raynerstrings
I acknowledge the Traditional Custodians of the land on which I work, the Wurundjeri
people of the Kulin nation, and pay my respect to their Elders, past and present
I am sending this email when convenient for me, please only respond when convenient for
you
2:46 p.m.
Yes, shell-cd does the work, try it for yourself by hitting M-: and
typing the relevant expression at the minibuffer.
prayner(a)unimelb.edu.au writes:
Ok, could you also test manually that it's shell-cd that's
changing
the directory=3F
Oh and thanks for pointing out emacspeak-wizards-shell-by-key. I
should reread emacspeak-wizards.el more often.
thanks again
Peter
T.V Raman writes:
>prayner--- via Emacspeak <emacspeak(a)emacspeak.org> writes:
>
>I just tried it C-e F11 and it does change the directory correctly.=
>
>> I use this a bit to switch my shell buffer to the directory of th=
e
>> file from the current buffer, e.g. editing file and want to
do a =
git
>> commit.
>> At some point it seems to have stopped changing the current worki=
ng
>> directory for the shell itself. I've looked a little and
it seems=
the
>> shell-cd function used by emacspeak-wizards-shell-toggle
doesn't
>> change the shell's working directory.
>> Looking at the relevant commits:
>> git diff 9eaa5db1cbdb fab2a5cc74452d2 emacspeak-wizards.el
>>
>> diff --git a/lisp/emacspeak-wizards.el b/lisp/emacspeak-wizards.e=
l
>> index 4a2a85621..572349bba 100644
>> --- a/lisp/emacspeak-wizards.el
>> +++ b/lisp/emacspeak-wizards.el
>> @@ -735,10 +735,7 @@ If optional arg property is not supplied, re=
ad it interactively. "
>> (shell)
>> (unless (string-equal (expand-file-name dir)
>> (expand-file-name default-directory))
>> - (goto-char (point-max))
>> - (insert (format "pushd %s" dir))
>> - (comint-send-input)
>> - (shell-process-cd dir))
>> + (shell-cd dir))
>> (emacspeak-auditory-icon 'select-object)
>> (emacspeak-speak-mode-line)))
>> It looks like explicit interaction with the shell process was rem=
oved.
>> Was that the intent=3F fwiw I prefer the old behaviour.
>> cheers
>> Peter
>
>--=20
>
>Thanks,
>
>--Raman(I Search, I Find, I Misplace, I Research)
>=E2=99=89 Id: kg:/m/0285kf1 =F0=9F=A6=AE
>
=20
--=20
Peter Rayner (he/him), Level 1, 187 Grattan St.
Academic Lead - Climate & Energy College <https://www.climatecollege=
.unimelb.edu.au>
mobile +61 402 752 379, skype: petermorag=20
zoom id 4431343191, join at <https://unimelb.zoom.us/j/4431343191=3F=
pwd=3Da1E5Z3JEOTRVQUJsaVdRbVUvR1QyZz09>
mail-to: prayner(a)unimelb.edu.au TWITTER: @raynerstrings
I acknowledge the Traditional Custodians of the land on which I work=
, the Wurundjeri people of the Kulin nation, and pay my respect to thei=
r Elders, past and present
I am sending this email when convenient for me, please only respond
=
when convenient for you
--=20
Thanks,
--Raman(I Search, I Find, I Misplace, I Research)
=E2=99=89 Id: kg:/m/0285kf1 =F0=9F=A6=AE
--
Thanks,
--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1 🦮
518
days inactive
522
days old
4 comments
2 participants
participants (2)
-
prayner＠unimelb.edu.au -
T.V Raman